Fix glossary termId → ref to match spec#95
Merged
gvonness-apolitical merged 1 commit intomainfrom Feb 16, 2026
Merged
Conversation
Same pattern as the citation ref → refs fix: update the glossary mark constructor to emit "ref" instead of "termId", add backward-compat helpers (get_glossary_ref, normalize_glossary_attrs), and update GlossaryRef serde to serialize as "ref" while accepting both forms. Bump version to 0.7.0 (wire format change).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtensionMark::glossary()to emit"ref"instead of"termId", matching the spec'sglossaryMarkschemaGlossaryRefserde to serialize as"ref"withalias = "termId"for backward compatibilityget_glossary_ref()andnormalize_glossary_attrs()helpers (same pattern as the citation fix in Fix citation ref → refs to support multi-citation clusters #93)Test plan
cargo test --workspace --all-features— 1055 tests passschema_glossary_emits_refverifies new output uses"ref"and"termId"is absenttest_get_glossary_ref_legacyverifies old"termId"documents are still readabletest_normalize_glossary_attrsverifies in-place migration from"termId"→"ref"GlossaryRefstruct roundtrips with both"ref"and"termId"input